Skip to content

fix: roadmap page not adapting to light theme - #259

Merged
mugenkyou merged 1 commit into
mugenkyou:mainfrom
AribaRazi:fix/light-theme-roadmap
May 11, 2026
Merged

fix: roadmap page not adapting to light theme#259
mugenkyou merged 1 commit into
mugenkyou:mainfrom
AribaRazi:fix/light-theme-roadmap

Conversation

@AribaRazi

Copy link
Copy Markdown
Contributor

Pull Request Summary

Fix light/dark theme inconsistency across various roadmap pages (AIML,DSA,BLOCKCHAIN etc.) . Several elements were using hardcoded dark color values instead of CSS variables, causing them to remain dark even when the light theme was active. Fixes #255


Changes Introduced

  1. Replaced hardcoded .section-header background gradient with var(--timeline-card-bg) so roadmap cards correctly switch between dark and light themes
  2. Added [data-theme="light"] overrides for .section-title, .section-description, and .section-content li to ensure readable text in light mode
  3. Fixed .roadmap-hero background by replacing hardcoded #0f172a dark gradient with a light-mode override using linear-gradient(135deg, #f1f5f9 0%, #e2e8f0 100%)
  4. Fixed hero h1 which used -webkit-text-fill-color: transparent with a white gradient, making it invisible in light mode — replaced with color: var(--text-main) and added light-mode gradient override
  5. Added [data-theme="light"] override for .hero-progress-card to show white background with proper shadow

Screenshots

image image

BEFORE CHANGES:

image

AFTER CHANGES

image

Checklist

Please ensure the following before requesting review:

  • Code follows project conventions and best practices.
  • Feature or fix works correctly on both mobile and desktop.
  • No new console errors or accessibility regressions.
  • Documentation updated if applicable.
  • Visuals attached for UI-related updates.

Additional Notes

All fixes are CSS-only — no HTML or JavaScript was modified. Light mode and dark mode have been manually verified across the hero section, timeline cards, progress bars, and navigation.

@github-actions github-actions Bot added awaiting review bug Something isn't working level-2 Intermediate issue; moderate JS or UI work, needs some project understanding. nsoc26 labels May 5, 2026
@github-actions
github-actions Bot requested a review from mugenkyou May 5, 2026 16:47
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

📥 Pull Request Received

Thank you for your contribution to College Daddy. Your pull request has been received and is currently under review.

🔗 Linked Issues

✅ Pre-Merge Checklist

Please ensure the following requirements are met:

  • Changes adhere to contribution guidelines
  • Related issues are referenced in description
  • All changes tested and verified locally
  • Code follows project standards

👤 Reviewer Assigned

@mugenkyou has been assigned to review this pull request.


Our team will review your submission shortly. We appreciate your effort in improving the platform for students.

@mugenkyou
mugenkyou merged commit bd1c02e into mugenkyou:main May 11, 2026
1 of 2 checks passed
@github-actions

Copy link
Copy Markdown

🎉 Pull Request Merged Successfully

Contributor: @AribaRazi

Your pull request has been successfully merged into the main codebase. Thank you for your valuable contribution to College Daddy.

🚀 Next Steps

We encourage you to:

  • ⭐ Star the repository to support the project
  • 👀 Watch for updates and participate in discussions
  • 🔄 Continue contributing to enhance the platform

We value your commitment to improving educational technology and look forward to your continued involvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working level-2 Intermediate issue; moderate JS or UI work, needs some project understanding. nsoc26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Light Theme Not Applied Consistently on AI/ML Roadmap Page (Roadmap Section Remains Dark)

2 participants