Mobile Side Panel Overlap fixed - #300
Open
Girish0902 wants to merge 3 commits into
Open
Conversation
📥 Pull Request ReceivedThank you for your contribution to College Daddy. Your pull request has been received and is currently under review. 🔗 Linked Issues
✅ Pre-Merge ChecklistPlease ensure the following requirements are met:
👤 Reviewer Assigned@mugenkyou has been assigned to review this pull request. Our team will review your submission shortly. We appreciate your effort in improving the platform for students. |
Author
|
@mugenkyou , I have successfully resolve the issue plz check it and add labels nsoc level 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Briefly describe what this PR accomplishes and why it’s needed.
Fixes an issue where the mobile side-panel navigation was clipped and partially obscured by the sticky header on small screens. The problem was caused by the header creating a localized stacking/containing context due to its
backdrop-filterproperty, paired with the fact that the mobile nav panel lived inside the header container within the DOM tree.Reference any related issues (e.g.,
Fixes #12).Fixes: Mobile side panel overlap in the Attendance screen.
Changes Introduced
List the key changes made in this PR:
.nav-linkscompletely out of the header block and into the rootdocument.bodyframework on mobile viewports, smoothly restoring it back during desktop screen resizes.body.nav-openstate utility class toggle to dynamically alter header styles whenever the mobile side menu overlay triggers active.backdrop-filterrules while the mobile navigation pane remains open, preventing the browser from trapping fixed-position children under the header bounds..nav-overlayand the active mobile.nav-linksstructure to clearly map them comfortably above the header surface stack.Screenshots / Demo (for UI changes)
If applicable, include before-and-after visuals to illustrate the impact.
| Before |
| After |
Checklist
Please ensure the following before requesting review:
Additional Notes
Add any relevant context, design considerations, or follow-up tasks here.
document.bodyavoids structural stacking bugs without breaking semantic layout requirements for accessibility screen readers.