Skip to content

changed fragment to show 404 when discussion tab is clicked #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhammadadeeltajamul wants to merge 3 commits into
base: master
Choose a base branch
from
Open

changed fragment to show 404 when discussion tab is clicked #5

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aca3cfe
changed fragment to show 404 when discussion tab is clicked
Jan 4, 2022
3699a84
Added a new flag 'discussion.disable_discussion_tab' to disable discu…
Jan 17, 2022
cc36006
Raising 404 error instead of printing 404 error when disabled discuss…
Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lms/djangoapps/discussion/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,7 @@ def render_to_fragment( # lint-amnesty, pylint: disable=arguments-differ
else:
html = render_to_string('discussion/discussion_board_fragment.html', context)

html = "Error 404: NOT Found"
fragment = Fragment(html)
self.add_fragment_resource_urls(fragment)
inline_js = render_to_string('discussion/discussion_board_js.template', context)
Expand Down