Repository navigation
Conversation
rvitaliy
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
November 5, 2026 09:35
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 56s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
zannager
added
the
component: combobox
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5574.
Dismiss the IME preview after an accepted item-selection fill or clear, including reselecting the current value. Preserve canceled changes and Android composition commits; ignore a trailing
compositionendafter the preview was replaced.The approach follows #5579, with resets limited to selection-related writes. iOS keeps its existing behavior due to WebKit #255857. Multiple selection with the input outside the popup is unchanged.
Regression tests use English words and native Chromium IME composition through CDP. They fail without the fix.
Validation: Combobox/Autocomplete jsdom (1,153 passed), Chromium (1,239 passed), E2E (12 passed), TypeScript, ESLint, Stylelint, and Prettier.
AI assistance: Codex helped implement, review, and test this change.