New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Error when installing in unsupported node environments #25798

Closed

eps1lon wants to merge 2 commits into next from core/exports-resolution

Member

eps1lon commented Apr 16, 2021

Based on #25795

We have this kind of dangerous stack of technical debt that is pinning us down:

Can't use exports with webpack 4
1. Can't use webpack 5 because of inline loader not migrateable to webpack 5 when used in require.context webpack/webpack#12900
  1. Can't resolve inline loader not migrateable to webpack 5 when used in require.context webpack/webpack#12900 with getStaticProps because of getStaticProps on _app vercel/next.js#10949
2. Can't use webpack 5 because Bundle is invalid when used in an existing repository codymikol/karma-webpack#505
  1. Can't drop karma because there's no alternative (I have no idea how one would use browserstack)
Can't use exports because of Support for package.json exports and imports ? import-js/eslint-plugin-import#1868 (arguably the easiest since we should just be able to drop import/resolve)

eps1lon added 2 commits

April 16, 2021 17:54


          [core] Error when installing in unsupported node environments

4188b2a


          [core] Use exports instead of aliases where possible

1b24a81

eps1lon added the core label

Member Author

eps1lon commented Apr 16, 2021

Accidentally pushed to upstream

eps1lon closed this

eps1lon deleted the core/exports-resolution branch

April 16, 2021 16:38

mui-pr-bot commented Apr 16, 2021 •

edited

Loading

No bundle size changes

Generated by 🚫 dangerJS against 1b24a81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core