Fix strict and strictEffects not enabling Strict Mode in React 19
#45630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
bernardobelchior
force-pushed
the
fix-test-utils-strict-mode-react-19
branch
from
fdf1f5e to
f853929
Compare
github-actions
bot
removed
the
PR: out-of-date
bernardobelchior
force-pushed
the
fix-test-utils-strict-mode-react-19
branch
from
f853929 to
e4923ef
Compare
Netlify deploy previewhttps://deploy-preview-45630--material-ui.netlify.app/ Bundle size report |
bernardobelchior
force-pushed
the
fix-test-utils-strict-mode-react-19
branch
from
fcc7e44 to
8fcf935
Compare
github-actions
bot
added
the
PR: out-of-date
bernardobelchior
force-pushed
the
fix-test-utils-strict-mode-react-19
branch
from
e6cea70 to
7f5f581
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
strictandstrictEffectsnot enabling Strict Mode in React 19.Failing test before the fix: https://app.circleci.com/pipelines/github/mui/material-ui/150321/workflows/b726b7ae-d5cf-4759-bd41-b025f7c04dec/jobs/807845
Bug reproduction opened in React Testing Library: testing-library/react-testing-library#1388
Many tests were failing, so I had to fix them. On most of them, I've disabled strict mode. That solution didn't work for the two
Autocomplete.test.tsxtests, so I changed the assertion.