Skip to content

[code-infra] Pass through ARGOS_THRESHOLD variable #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
Merged

[code-infra] Pass through ARGOS_THRESHOLD variable #766

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78d3bf7
[code-infra] Pass through ARGOS_THRESHOLD variable
Janpot Oct 1, 2025
1f501ba
Update cmdArgosPush.mjs
Janpot Oct 1, 2025
e1c0636
Update cmdArgosPush.mjs
Janpot Oct 1, 2025
a232008
Merge branch 'master' into argos-threshold
Janpot Oct 3, 2025
b5565ac
Merge branch 'master' into argos-threshold
Janpot Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/code-infra/src/cli/cmdArgosPush.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
const screenshots = await globby(`${folder}/**/*`, {
onlyFiles: true,
});
const threshold = process.env.ARGOS_THRESHOLD ? parseFloat(process.env.ARGOS_THRESHOLD) : 0.5;

console.log(`Found ${screenshots.length} screenshots.`);
console.log(
`Found ${screenshots.length} screenshots. Uploading with threshold ${threshold}.`,
);
if (verbose) {
console.log('Screenshots found:');
screenshots.forEach((screenshot) => {
Expand Down Expand Up @@ -99,14 +102,22 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({
commit: circleSha1,
branch: circleBranch,
token: argosToken,
threshold,
parallel: {
total: batches.length,
nonce: circleBuildNum,
},
});

if (verbose) {
console.log('Screenshots uploaded:');
for (const screenshot of result.screenshots) {
console.log(`- ${screenshot.name}. Threshold: ${screenshot.threshold}.`);
}
}

console.log(
`Batch of ${batches[i].length} screenshots uploaded. Build URL: ${result.build.url}`,
`Batch of ${batches[i].length} screenshots uploaded. Threshold: ${threshold}. Build URL: ${result.build.url}`,
);
}
} finally {
Expand Down
Loading