-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts][docs] Add docs for rounded symbol #15324
[charts][docs] Add docs for rounded symbol #15324
Conversation
Deploy preview: https://deploy-preview-15324--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #15324 will not alter performanceComparing Summary
|
I was worried that this wouldn't work on Safari https://developer.mozilla.org/en-US/docs/Web/CSS/ry#values but this is wrong, fixing that in: mdn/browser-compat-data#24991. |
docs/data/charts/legend/legend.md
Outdated
### Rounded symbol | ||
|
||
To create a rounded symbol, use the `sx` prop to style the symbol class directly. Import `legendClasses.mark` to target the symbol, and set the `ry` property to control the symbol's corner radius. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Rounded symbol | |
To create a rounded symbol, use the `sx` prop to style the symbol class directly. Import `legendClasses.mark` to target the symbol, and set the `ry` property to control the symbol's corner radius. | |
### Rounded symbol | |
To create a rounded symbol, use the `legendClasses.mark` to apply CSS on marks. | |
Notice that SVG `rect` uses `ry` property to control the symbol's corner radius instead of `border-radius`. |
I propose to be more generic, because sx
is not the only way we can pass CSS to the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@michelengelen might be good to add an alternative way of cherrypicking if the PR was merged with the wrong tags 🙃 I would suggest some sort of behaviour using |
Fix #12538
Preview: https://deploy-preview-15324--material-ui-x.netlify.app/x/react-charts/legend/#rounded-symbol