[DataGrid] Fix order of spread props on toolbar items #15556
Merged
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15556--material-ui-x.netlify.app/ |
michelengelen
added
component: data grid
oliviertassinari
added
bug 🐛
romgrk
approved these changes
Nov 25, 2024
KenanYusuf
added
needs cherry-pick
|
Cherry-pick PRs will be created targeting branches: v7.x |
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
| onClick={showColumns} | ||
| {...rootProps.slotProps?.baseButton} | ||
| {...buttonProps} |
There was a problem hiding this comment.
hey @KenanYusuf i am seeing that this causes the showColumns function to not being called if the onClick is defined by the consumer
meaning the popover is not displayed to the user
the usecase for this would be to execute some code when the button is clicked (but the popover should still be shown)
There was a problem hiding this comment.
Thanks for raising @marcelo-cardozo - I've created an issue so you can track the fix here #16354
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the order of props being spread to toolbar items. Applying props to the individual toolbar items should take precedence over slot props applied at the root level.
Also added the ability to override badge props for
GridToolbarFilterButton.Fixes #13416
Closes #15550