Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update @mui/monorepo #15574

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 23, 2024

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes dependencies Update of dependencies labels Nov 23, 2024
@mui-bot
Copy link

mui-bot commented Nov 23, 2024

Deploy preview: https://deploy-preview-15574--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2d8b9a4

renovate bot and others added 2 commits November 23, 2024 20:33
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
Indeed, moving docs resources to shared/reused location would remove the need to sync that data once in a while. 👌
I understand, that it is the end goal we are moving towards with all the migration.

@oliviertassinari oliviertassinari merged commit ead5d30 into mui:v7.x Nov 25, 2024
17 checks passed
@oliviertassinari oliviertassinari deleted the upgrade-docs-infra branch November 25, 2024 13:53
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 25, 2024

Indeed, moving docs resources to shared/reused location would remove the need to sync that data once in a while.

@LukasTy I don't know about having a shared/reused location, but here, the bug is that docs-infra doesn't have atomic deployments. We ship URLs and GitHub at different times. It can't work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants