Skip to content

[DataGridPro] Fix header select checkbox state with checkboxSelectionVisibleOnly and paginationMode="server" #17026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

arminmeh
Copy link
Contributor

Fixes #17005

Maybe an example with a bit more context would help (#17005 (comment))

I don't see a benefit of using checkboxSelectionVisibleOnly and paginationMode="server" because you are seeing all rows anyway.

But, we can fix the issue regardless.

@arminmeh arminmeh added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user feature: Selection Related to the data grid Selection feature labels Mar 18, 2025
@arminmeh arminmeh requested a review from a team March 18, 2025 15:49
Copy link

Thanks for adding a type label to the PR! 👍

@arminmeh arminmeh added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Mar 18, 2025
@mui-bot
Copy link

mui-bot commented Mar 18, 2025

Deploy preview: https://deploy-preview-17026--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0918de1

@arminmeh arminmeh force-pushed the fix-visible-selection branch from 1b48d48 to 0918de1 Compare March 18, 2025 16:00
@arminmeh arminmeh merged commit a7f24b3 into mui:master Mar 19, 2025
22 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user v7.x
Projects
None yet
3 participants