Skip to content

[code-infra] Update more data-grid tests for vitest#17146

Merged
JCQuintas merged 8 commits intomui:masterfrom
JCQuintas:data-grid
Mar 26, 2025
Merged

[code-infra] Update more data-grid tests for vitest#17146
JCQuintas merged 8 commits intomui:masterfrom
JCQuintas:data-grid

Conversation

@JCQuintas
Copy link
Copy Markdown
Member

These are improvements made during the vitest PR

I'm moving the changes out so that PR is leaner.

The changes mostly revolve around:

  • removing clock='fake' usage.
  • using user events rather than fireEvent where applicable.

Notable change:

@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 26, 2025

Deploy preview: https://deploy-preview-17146--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 059e2fb

@JCQuintas JCQuintas changed the title [code-infra] [code-infra] Update more data-grid tests for vitest Mar 26, 2025
@JCQuintas JCQuintas requested review from a team March 26, 2025 18:59
@JCQuintas JCQuintas marked this pull request as ready for review March 26, 2025 18:59
Copy link
Copy Markdown
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such tedious work, thanks for doing it 😅

@JCQuintas
Copy link
Copy Markdown
Member Author

JCQuintas commented Mar 26, 2025

Such tedious work, thanks for doing it 😅

😆 I've been doing them through the course of months now, just want to get it done hahahaha

@JCQuintas JCQuintas merged commit 56a53a2 into mui:master Mar 26, 2025
21 checks passed
@JCQuintas JCQuintas deleted the data-grid branch March 26, 2025 19:11
@oliviertassinari oliviertassinari added internal Behind-the-scenes enhancement. Formerly called “core”. scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed maintenance labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. scope: data grid Changes related to the data grid. test type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants