Skip to content

Commit

Permalink
Fixes based on feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Pururun committed Dec 20, 2024
1 parent 61e2f6e commit ab3d61f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/android-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,13 @@ jobs:
strategy:
matrix:
include:
- arch: "x86_64"
abi: "x86_64"
- abi: "x86_64"
task-variant: "X86_64"
- arch: "i686"
abi: "x86"
- abi: "x86"
task-variant: "X86"
- arch: "aarch64"
abi: "arm64-v8a"
- abi: "arm64-v8a"
task-variant: "Arm64"
- arch: "armv7"
abi: "armeabi-v7a"
- abi: "armeabi-v7a"
task-variant: "Arm"
steps:
# Fix for HOME path overridden by GH runners when building in containers, see:
Expand Down Expand Up @@ -222,7 +218,7 @@ jobs:
- name: Upload native libs
uses: actions/upload-artifact@v4
with:
name: native-libs-${{ matrix.arch }}
name: native-libs-${{ matrix.abi }}
path: android/app/build/rustJniLibs/android
if-no-files-found: error
retention-days: 7
Expand Down
3 changes: 0 additions & 3 deletions android/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,6 @@ tasks.register<Exec>("generateRelayList") {
workingDir = File(repoRootPath)
standardOutput = ByteArrayOutputStream()

// Set this if you get a cargo not found error
// environment =

onlyIf { isReleaseBuild() || !relayListPath.exists() }

commandLine("cargo", "run", "--bin", "relay_list")
Expand Down
2 changes: 1 addition & 1 deletion wireguard-go-rs/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ fn android_move_binary(binary: &Path, output: &Path) -> anyhow::Result<()> {

let mut copy_command = Command::new("cp");
// -p command is required to preserve ownership and timestamp of the file to prevent a
// rebuild of this module everytime.
// rebuild of this module every time.
copy_command
.arg("-p")
.arg(binary.to_str().unwrap())
Expand Down

0 comments on commit ab3d61f

Please sign in to comment.