Run cargo deny in the test framework
#5942
Conversation
|
Right, |
MarkusPettersson98
force-pushed
the
run-cargo-deny-on-testframework-des-674
branch
from
fa6435b to
7b6dc58
Compare
There was a problem hiding this comment.
Unfortunately that we need to duplicate so much deny-info. But let's merge this so we get the CI up to speed at least. Hopefully we can simplify it at a later point in time.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
.github/workflows/testframework-rust-supply-chain.yml line 7 at r2 (raw file):
paths: - .github/workflows/testframework-rust-supply-chain.yml - deny.toml
This is now the wrong deny.toml
MarkusPettersson98
force-pushed
the
run-cargo-deny-on-testframework-des-674
branch
from
fbdcee3 to
6b5efa0
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @faern)
.github/workflows/testframework-rust-supply-chain.yml line 7 at r2 (raw file):
Previously, faern (Linus Färnstrand) wrote…
This is now the wrong
deny.toml
Well spotted, fixed!
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
run-cargo-deny-on-testframework-des-674
branch
from
6b5efa0 to
6ab1030
Compare
Security advisories`RUSTSEC-2023-0081` makes `cargo deny` fail when running it from the test workspace. No fixes have been released for any of our dependencies which triggers these security advisories, so we have litle choise other than ignoring them for now and keeping an eye out for updates upstream.
MarkusPettersson98
force-pushed
the
run-cargo-deny-on-testframework-des-674
branch
from
6ab1030 to
31a74b9
Compare
This PR adds a new CI job for the test framework CI - run
cargo denyto guard against supply chain vulnerabilities.This is one step towards bringing the CI for the test framework on par with main workspace CI.
Open questions
In some sense it would be nice to have a separatedeny.tomlin thetestworkspace, but on the other hand it would be hard to keep them in sync with everything that should be shared across them. For now, I put thetestworkspace specificRUSTSECadvisories to allow temporarily in the maindeny.toml🤷Answer: Duplicate
deny.tomlin thetestworkspace and modify as needed 📜 🖊️This change is