Clean up dialogs

[Pururun]

Clean up task:

• Moved all infodialogs into their own package ot make the dialog package.
• Made some more dialogs use DeleteConfirmationDialog
• Renamed DeleteConfirmationDialog to NegativeConfirmationDialog
• Added support for AnnotatedString to NegativeConfirmationDialog
• Removed HtmlText as the last instance where it was used was replaced with AnnotatedString
• Added InputDialog and made all input dialogs except redeem voucher dialog use it.

---

This change is 

[linear]

DROID-1250 Create base component for error dialog

[albin-mullvad]

Reviewed 17 of 25 files at r1, all commit messages.
Reviewable status: 17 of 25 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

-- commits line 5 at r1:
typo: dialogs

Code quote:

dialog

[Rawa]

Reviewed 3 of 25 files at r1, 22 of 22 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/NegativeConfirmationDialog.kt line 50 at r4 (raw file):

fun NegativeConfirmationDialog(
    message: String,
    messageStyle: TextStyle? = null,

Shouldn't these be the same for all NegativeConfrimationDialog? Or when do we change the message style? I saw the NoEmail for error report seems to have a different style.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/NegativeConfirmationDialog.kt line 51 at r4 (raw file):

    message: String,
    messageStyle: TextStyle? = null,
    errorMessage: String?,

Maybe null as default? Then we don't have to define it on the call side if it does not have a message.

[Pururun]

Reviewable status: 16 of 25 files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/NegativeConfirmationDialog.kt line 50 at r4 (raw file):

Previously, Rawa (David Göransson) wrote…

Shouldn't these be the same for all NegativeConfrimationDialog? Or when do we change the message style? I saw the NoEmail for error report seems to have a different style.

It is used by NoEmail and RemoveDevice. In the case of no email it is because the text is quite long, in the case of remove device it is because it has some text that is bold so the normal text needs to be non-bold.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/NegativeConfirmationDialog.kt line 51 at r4 (raw file):

Previously, Rawa (David Göransson) wrote…

Maybe null as default? Then we don't have to define it on the call side if it does not have a message.

Done.

[Pururun]

Reviewable status: 16 of 26 files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/NegativeConfirmationDialog.kt line 50 at r4 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

It is used by NoEmail and RemoveDevice. In the case of no email it is because the text is quite long, in the case of remove device it is because it has some text that is bold so the normal text needs to be non-bold.

I tested a few different configuration for this and I think we should keep it as is and then look into it again when we look into fonts and text styles.

[Rawa]

Reviewed 8 of 9 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Rawa]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved