Merged
Conversation
MarkusPettersson98
approved these changes
Oct 31, 2024
Contributor
MarkusPettersson98
left a comment
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Don't both print the contained error in the Display impl and also return it in source
faern
force-pushed
the
fix-encrypted-dns-error-source
branch
from
b2055bf to
724809a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't both print the contained error in the Display impl and also return it in source.
The error, as it was before, would print an error chain like this:
An error should avoid including its source error in its own
Displayimpl. Or, if it is included, it should not return that from thesourcemethod.If you want to dive more into how long I have cared about this, you can follow this URL :D rust-lang/api-guidelines#210
This change is