-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent apt
from being confused about mullvad-vpn
package version
#7125
Prevent apt
from being confused about mullvad-vpn
package version
#7125
Conversation
26df5ba
to
53c17b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 9 of 10 files at r2.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-runner/src/package.rs
line 176 at r2 (raw file):
cmd.args(["-o", "DPkg::Lock::Timeout=60"]); cmd.arg("-qy"); // `apt` may sporadically consider installing a development build to be a downgrade from the baseline stable
We could be more specific about the bug behavior here just to document it somewhere, e.g. "apt
may consider installing a development build to be a downgrade from the baseline stable if the major version is identical, in which case the ordering is incorrectly based on the git hash suffix"
5297529
to
1db272f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 15 files reviewed, 1 unresolved discussion (waiting on @Serock3)
test/test-runner/src/package.rs
line 176 at r2 (raw file):
Previously, Serock3 (Sebastian Holmin) wrote…
We could be more specific about the bug behavior here just to document it somewhere, e.g. "
apt
may consider installing a development build to be a downgrade from the baseline stable if the major version is identical, in which case the ordering is incorrectly based on the git hash suffix"
That's a good idea. Updated the comment, please let me know what you think 😊
1db272f
to
aba615f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 7 of 7 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-manager/src/tests/install.rs
line 119 at r5 (raw file):
.app_package_filename .contains(&running_daemon_version), Error::DaemonVersion {
The Error::DaemonVersion
variant is probably not needed, you could replace it with just a formatted error message.
aba615f
to
c9af76a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 15 files reviewed, 1 unresolved discussion (waiting on @Serock3)
test/test-manager/src/tests/install.rs
line 119 at r5 (raw file):
Previously, Serock3 (Sebastian Holmin) wrote…
The
Error::DaemonVersion
variant is probably not needed, you could replace it with just a formatted error message.
You're right! Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
c9af76a
to
e2d67b8
Compare
Sometimes, apt thinks that some installs are downgrades due to the dev version hash being lower than the baseline version hash. This PR makes the test framework add
--allow-downgrades
toapt
when installing the app. To make sure that we are running the expected app version, a runtime check has been added to thetest_upgrade_app
test.This change is