Replace nseventmonitor with nseventforwarder
#7178
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
There was a problem hiding this comment.
Reviewed 16 of 19 files at r1, all commit messages.
Reviewable status: 16 of 19 files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
upstream-nseventforwarder
branch
2 times, most recently
from
e1ed47d to
4133949
Compare
MarkusPettersson98
requested review from
hulthe
and removed request for
Serock3
There was a problem hiding this comment.
Reviewed 2 of 19 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
upstream-nseventforwarder
branch
2 times, most recently
from
a90cb1a to
7b960dd
Compare
There was a problem hiding this comment.
Reviewed 3 of 19 files at r1, 1 of 2 files at r3.
Reviewable status: 18 of 19 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98 and @Serock3)
desktop/packages/nseventforwarder/build.sh line 46 at r3 (raw file):
PLATFORM_DIR="dist/$PLATFORM_DIR_NAME" mkdir -p $PLATFORM_DIR cp "target/$TARGET_TRIPLE/release/libnseventforwarder.dylib" "$PLATFORM_DIR/index.node"
What about my CARGO_TARGET_DIR? :'(
MarkusPettersson98
force-pushed
the
upstream-nseventforwarder
branch
from
7b960dd to
310101e
Compare
MarkusPettersson98
force-pushed
the
upstream-nseventforwarder
branch
from
310101e to
cbe1f78
Compare
There was a problem hiding this comment.
Reviewable status: 17 of 19 files reviewed, 1 unresolved discussion (waiting on @hulthe and @Serock3)
desktop/packages/nseventforwarder/build.sh line 46 at r3 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
What about my CARGO_TARGET_DIR? :'(
No can do:(
There was a problem hiding this comment.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status:
desktop/packages/nseventforwarder/build.sh line 46 at r3 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
What about my CARGO_TARGET_DIR? :'(
Fair enough :)
MarkusPettersson98
merged commit cbe1f78
into
test-npm-workspace
This PR replaces NSEventMonitor with a fresh Rust-dito:
nseventforwarder🎉This change is