Make nseventforwarder member of root cargo workspace#7211
Merged
MarkusPettersson98 merged 3 commits intomainfrom Nov 21, 2024
Merged
Make nseventforwarder member of root cargo workspace#7211MarkusPettersson98 merged 3 commits intomainfrom
nseventforwarder member of root cargo workspace#7211MarkusPettersson98 merged 3 commits intomainfrom
Conversation
1c32614 to
f51ce4a
Compare
hulthe
previously approved these changes
Nov 20, 2024
Contributor
hulthe
left a comment
There was a problem hiding this comment.
Nice! This fixes my previous issue where i had to manually build nseventforwarder :D
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
desktop/packages/nseventforwarder/package.json line 12 at r1 (raw file):
"build-debug": "npm run cargo-build && mkdir -p debug && cp ${CARGO_TARGET_DIR:-../../../target}/debug/libnseventforwarder.dylib debug/index.node", "build-arm": "npm run cargo-build -- --release --target aarch64-apple-darwin && mkdir -p dist/darwin-arm64 && cp ${CARGO_TARGET_DIR:-../../../target}/aarch64-apple-darwin/release/libnseventforwarder.dylib dist/darwin-arm64/index.node", "build-x86": "npm run cargo-build -- --release --target x86_64-apple-darwin && mkdir -p dist/darwin-x64 && cp ${CARGO_TARGET_DIR:--../../../target}/x86_64-apple-darwin/release/libnseventforwarder.dylib dist/darwin-x64/index.node",
✨
raksooo
previously approved these changes
Nov 21, 2024
Member
raksooo
left a comment
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
9bf0ae7 to
baeb9eb
Compare
03e66c5
baeb9eb to
03e66c5
Compare
raksooo
approved these changes
Nov 21, 2024
Member
raksooo
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Rust-Node module
nseventforwarderfrom its own cargo workspace to the root cargo workspace. It updates relevant scripts and fixes lints that are enabled in its new workspace but not the old one.This change is