Skip to content

Make nseventforwarder member of root cargo workspace#7211

Merged
MarkusPettersson98 merged 3 commits intomainfrom
add-nseventforwarder-to-main-workspace
Nov 21, 2024
Merged

Make nseventforwarder member of root cargo workspace#7211
MarkusPettersson98 merged 3 commits intomainfrom
add-nseventforwarder-to-main-workspace

Conversation

@MarkusPettersson98
Copy link
Copy Markdown
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Nov 20, 2024

This PR moves the Rust-Node module nseventforwarder from its own cargo workspace to the root cargo workspace. It updates relevant scripts and fixes lints that are enabled in its new workspace but not the old one.


This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 force-pushed the add-nseventforwarder-to-main-workspace branch from 1c32614 to f51ce4a Compare November 20, 2024 14:39
@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review November 20, 2024 14:39
hulthe
hulthe previously approved these changes Nov 20, 2024
Copy link
Copy Markdown
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This fixes my previous issue where i had to manually build nseventforwarder :D

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


desktop/packages/nseventforwarder/package.json line 12 at r1 (raw file):

    "build-debug": "npm run cargo-build && mkdir -p debug && cp ${CARGO_TARGET_DIR:-../../../target}/debug/libnseventforwarder.dylib debug/index.node",
    "build-arm": "npm run cargo-build -- --release --target aarch64-apple-darwin && mkdir -p dist/darwin-arm64 && cp ${CARGO_TARGET_DIR:-../../../target}/aarch64-apple-darwin/release/libnseventforwarder.dylib dist/darwin-arm64/index.node",
    "build-x86": "npm run cargo-build -- --release --target x86_64-apple-darwin && mkdir -p dist/darwin-x64 && cp ${CARGO_TARGET_DIR:--../../../target}/x86_64-apple-darwin/release/libnseventforwarder.dylib dist/darwin-x64/index.node",

raksooo
raksooo previously approved these changes Nov 21, 2024
Copy link
Copy Markdown
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 force-pushed the add-nseventforwarder-to-main-workspace branch 2 times, most recently from 9bf0ae7 to baeb9eb Compare November 21, 2024 08:00
@MarkusPettersson98 MarkusPettersson98 dismissed stale reviews from raksooo and hulthe via 03e66c5 November 21, 2024 08:04
@MarkusPettersson98 MarkusPettersson98 force-pushed the add-nseventforwarder-to-main-workspace branch from baeb9eb to 03e66c5 Compare November 21, 2024 08:04
Copy link
Copy Markdown
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit d23ccc8 into main Nov 21, 2024
@MarkusPettersson98 MarkusPettersson98 deleted the add-nseventforwarder-to-main-workspace branch November 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants