Shadowsocks config: Prevent the clearing of the SingleChoiceList custom value field from clobbering its value #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
IOS-953-shadowsocks-port-selector-bug
branch
from
6823f48 to
aa1b5a1
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subtle bug in event handling in SingleChoiceList meant that, when the user selected a non-custom value after editing the custom field, when the custom field was blanked, it would then be interpreted as a change of value, overriding the user's choice and breaking the list. This fixes this, only changing the value if the field is non-empty or the previous value was a custom value. In doing this, it fixes a bug in the Shadowsocks port selection view.
This change is