Add trailing status indicators for daita and multihop cells #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
requested review from
buggmagnet and
mojganii
and removed request for
buggmagnet
rablador
force-pushed
the
add-trailing-status-indicators-for-daita-and-multihop-ios-923
branch
2 times, most recently
from
175c953 to
3c410d0
Compare
rablador
commented
Dec 4, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved
ios/MullvadVPN/View controllers/Settings/SettingsInteractor.swift line 38 at r1 (raw file):
self.tunnelObserver = tunnelObserver }
Old stuff we don't need anymore.
ios/MullvadVPN/View controllers/Settings/SwiftUI components/SingleChoiceList.swift line 414 at r1 (raw file):
} } } // swiftlint:disable:this file_length
Opportunistic cleanup.
buggmagnet
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved
rablador
force-pushed
the
add-trailing-status-indicators-for-daita-and-multihop-ios-923
branch
from
3c410d0 to
9c27913
Compare
mojganii
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Reviewable status: 5 of 8 files reviewed, all discussions resolved
pinkisemils
force-pushed
the
add-trailing-status-indicators-for-daita-and-multihop-ios-923
branch
from
9c27913 to
f523a96
Compare
pinkisemils
deleted the
add-trailing-status-indicators-for-daita-and-multihop-ios-923
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is