-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility identifiers to SingleChoiceList rows and text fields #7273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)
ios/MullvadVPN/View controllers/Settings/SwiftUI components/SingleChoiceList.swift
line 223 at r1 (raw file):
customValueInput = "" } .accessibilityIdentifier(itemAccessibilityIdentifier(item))
Have we actually tested this ?
Since we have our own custom override of UIAccessibilityIdentification
which will try to case the value to the AccessibilityIdentifier
enum, if that string is not present in the raw
representation, it will just crash at runtime.
Or is SwiftUI using a different protocol for accessibility ?
Previously, buggmagnet wrote…
SwiftUI has a modifier which accepts a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
ca7ed9b
to
2972a55
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This adds the ability to add
accessibilityIdentifier
s to tappable rows and custom entry controls in aSingleChoiceList
, preparing it for UI tests.This change is