Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatic F-Droid publishing #7304

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

kl
Copy link
Contributor

@kl kl commented Dec 9, 2024


This change is Reviewable

@kl kl added the Android Issues related to Android label Dec 9, 2024
Copy link

linear bot commented Dec 9, 2024

@kl kl changed the title Enable automatic F-Droid publishing Support automatic F-Droid publishing Dec 9, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @kl)


prepare-release.sh line 78 at r1 (raw file):

    echo "$PRODUCT_VERSION" > dist-assets/android-version-name.txt
    cargo run -q --bin mullvad-version versionCode > dist-assets/android-version-code.txt
    git commit -S -m "Update android app version to $PRODUCT_VERSION" \

The version code should also be committed?


dist-assets/android-version-name.txt line 1 at r1 (raw file):

2024.9-beta1

nit: can this be moved to separate commit?


android/fdroid-build/env.sh line 10 at r1 (raw file):

# Ensure Go compiler is accessible
export GOROOT="$HOME/go"
export PATH="$GOROOT/bin:$PATH"

Can you add a separate commit where these PATH changes are explained as part of the commit message?

Code quote:

export PATH="$GOROOT/bin:$PATH"

dist-assets/android-version-code.txt line 1 at r1 (raw file):

24099000

nit: please generate this version code in a separate commit 🙏

Code quote:

24099000

@kl kl force-pushed the automatic-publishing-to-f-droid-droid-329 branch from ccfaaec to 413b9a5 Compare December 9, 2024 13:05
Copy link
Contributor Author

@kl kl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)


prepare-release.sh line 78 at r1 (raw file):

Previously, albin-mullvad wrote…

The version code should also be committed?

Done.


android/fdroid-build/env.sh line 10 at r1 (raw file):

Previously, albin-mullvad wrote…

Can you add a separate commit where these PATH changes are explained as part of the commit message?

Done.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

kl added 3 commits December 9, 2024 14:49
If the user has a previously installed Go version we need to put the
downloaded Go first in PATH for it to be found.
@Rawa Rawa force-pushed the automatic-publishing-to-f-droid-droid-329 branch from 413b9a5 to 5472bd4 Compare December 9, 2024 13:49
@Rawa Rawa merged commit 018fe96 into main Dec 9, 2024
49 of 51 checks passed
@Rawa Rawa deleted the automatic-publishing-to-f-droid-droid-329 branch December 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants