Merged
Conversation
MarkusPettersson98
requested review from
albin-mullvad,
faern,
pinkisemils and
raksooo
as code owners
pinkisemils
approved these changes
Dec 10, 2024
Collaborator
pinkisemils
left a comment
pinkisemils
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
approved these changes
Dec 10, 2024
Member
faern
left a comment
faern
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
MarkusPettersson98
force-pushed
the
silence-rustsec-2024-0421
branch
from
531610d to
6022cb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR silence
RUSTSEC-2024-0421incargo-denyandosv-scanner. AFAICT, we are not affected by this vulnerability as we do not accept domain names as input anywhere in the app.Currently we are blocked on getting rid of this vulnerability because of some dependencies of ours needing to cut new releases, most notably
hickory-protoandshadowsocks-rs. This is referenced in the comments in theosv-scanner.tomlfiles.This change is