Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dialogs for enabling bridge mode and adding custom dns #7359

Merged

Conversation

olmoh
Copy link
Collaborator

@olmoh olmoh commented Dec 18, 2024

  • Remove dialog for enabling bridge mode
  • Remove dialogs for adding custom dns
  • Streamline adding custom dns logic

This change is Reviewable

Copy link

linear bot commented Dec 18, 2024

@olmoh olmoh requested a review from raksooo December 18, 2024 06:48
@olmoh olmoh marked this pull request as ready for review December 18, 2024 10:19
@raksooo raksooo force-pushed the implement-move-information-in-popups-to-info-dialogs-des-1167 branch from 1531396 to d0f6b37 Compare December 20, 2024 17:05
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and Joakim made some changes to the custom lists dialog after talking to Matilda. The confirmation dialog shown when adding a local IP should still be included.

Reviewed 1 of 1 files at r1, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo requested a review from hulthe December 20, 2024 17:10
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the implement-move-information-in-popups-to-info-dialogs-des-1167 branch from d0f6b37 to eba34fc Compare December 20, 2024 17:12
@raksooo raksooo merged commit f34d216 into main Dec 20, 2024
11 checks passed
@raksooo raksooo deleted the implement-move-information-in-popups-to-info-dialogs-des-1167 branch December 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants