Ban async-std and old hyper and tokio versions #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
ban-more-unwanted-crates
branch
2 times, most recently
from
121cec8 to
369b038
Compare
raksooo
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
faern
force-pushed
the
ban-more-unwanted-crates
branch
from
369b038 to
2a8442f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to somewhat keep our dependency tree, compile times and bugs down, we should avoid certain crates. We already do this, but the list was very short. Here are some more crates that it would be good if we avoided (accidentally?) depending on. As long as there are viable alternatives we should never use these crates.
If we come to a situation where we really have no option, entries here can be discussed of course.
This change is