Remove direct winapi dependency from mullvad-daemon exception handling#7382
Merged
Remove direct winapi dependency from mullvad-daemon exception handling#7382
Conversation
faern
force-pushed
the
remove-direct-winapi-dep
branch
2 times, most recently
from
3fd81e0 to
cfc46e5
Compare
Member
Author
|
I had to make this PR a bit less glorious. To get the I could just vendor the constant. But getting rid of |
dlon
approved these changes
Dec 19, 2024
Member
dlon
left a comment
dlon
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
remove-direct-winapi-dep
branch
from
cfc46e5 to
b4ba15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still pull in
winapias a transitive dependency via a bunch of crates. But this PR at least tries to remove the last usage of it as a direct dependency. This makes very little difference in practice, but is a step towards only using a single binding for the Windows API.This change is