Use bridge interface IP from tart
#7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IP of the bridge interface was incorrectly assumed to be constant, but has at some point changed. This broke the algorithm for finding the bridge interface. Replace the algorithm with one based on the guest IP, which is given by `tart`. As the bridge IP is no longer constant, we also expose it through the `TEST_CONFIG`.
dlon
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Reviewed 11 of 11 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)
test/test-manager/src/vm/network/macos.rs line 47 at r2 (raw file):
} /// A hack to find the Tart bridge interface using `NON_TUN_GATEWAY`.
Comment is stale now (the part about NON_TUN_GATEWAY).
Serock3
force-pushed
the
all-macos-e2e-tests-have-failed-to-start-since-2024-12-12-des-1611
branch
from
67dc5e9 to
aab384f
Compare
dlon
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Serock3
deleted the
all-macos-e2e-tests-have-failed-to-start-since-2024-12-12-des-1611
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP of the bridge interface was incorrectly assumed to be constant, but has at some point changed. This broke the algorithm or finding the bridge interface.
Replace the algorithm with one based on the guest IP, which is given by
tart. As the bridge IP is no longer constant, we also expose it through theTEST_CONFIG.Test run: https://github.com/mullvad/mullvadvpn-app/actions/runs/12673264547
This change is