Show ip unavailble error message on desktop#7987
Conversation
| case TunnelParameterError.ipv6Unavailable: | ||
| return messages.pgettext( | ||
| 'notifications', | ||
| 'IPv6 is not available', | ||
| ); | ||
| } |
There was a problem hiding this comment.
The 'case TunnelParameterError.ipv6Unavailable:' statement is misaligned relative to the previous case, which may lead to confusion. Consider aligning it with the other case labels to improve readability and maintain consistency.
| case TunnelParameterError.ipv6Unavailable: | |
| return messages.pgettext( | |
| 'notifications', | |
| 'IPv6 is not available', | |
| ); | |
| } | |
| case TunnelParameterError.ipv6Unavailable: | |
| return messages.pgettext( | |
| 'notifications', | |
| 'IPv6 is not available', | |
| ); |
tobias-jarvelov
left a comment
There was a problem hiding this comment.
We could add translators comments as we strive to add those to all translations in the desktop app. Other than that it
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
desktop/packages/mullvad-vpn/src/shared/notifications/error.ts line 234 at r2 (raw file):
return messages.pgettext('notifications', 'IPv4 is not available'); case TunnelParameterError.ipv6Unavailable: return messages.pgettext('notifications', 'IPv6 is not available');
suggestion: We could add TRANSLATORS comments here to aid the crowdin translators:
case TunnelParameterError.ipv4Unavailable:
// TRANSLATORS: Label for notification when IPv4 is not available.
return messages.pgettext('notifications', 'IPv4 is not available');
case TunnelParameterError.ipv6Unavailable:
// TRANSLATORS: Label for notification when IPv6 is not available.
return messages.pgettext('notifications', 'IPv6 is not available');Code quote:
case TunnelParameterError.ipv4Unavailable:
return messages.pgettext('notifications', 'IPv4 is not available');
case TunnelParameterError.ipv6Unavailable:
return messages.pgettext('notifications', 'IPv6 is not available');85dc6a0 to
a9f2d11
Compare
|
@tobias-jarvelov Please check again |
Pururun
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @tobias-jarvelov)
desktop/packages/mullvad-vpn/src/shared/notifications/error.ts line 234 at r2 (raw file):
Previously, tobias-jarvelov (Tobias Järvelöv) wrote…
suggestion: We could add
TRANSLATORScomments here to aid the crowdin translators:case TunnelParameterError.ipv4Unavailable: // TRANSLATORS: Label for notification when IPv4 is not available. return messages.pgettext('notifications', 'IPv4 is not available'); case TunnelParameterError.ipv6Unavailable: // TRANSLATORS: Label for notification when IPv6 is not available. return messages.pgettext('notifications', 'IPv6 is not available');
Added
tobias-jarvelov
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
f7798e8 to
120d29e
Compare
This adds support for the same error message to the desktop frontend as was introduced on android in the following PR:
#7976
This change is