Skip to content

Update translations#8008

Merged
MarkusPettersson98 merged 1 commit intomainfrom
update-translations
Apr 15, 2025
Merged

Update translations#8008
MarkusPettersson98 merged 1 commit intomainfrom
update-translations

Conversation

@MarkusPettersson98
Copy link
Copy Markdown
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Apr 11, 2025

This PR updates the app with new translations for the coming 2025.6 release 🚀


This change is Reviewable

@dlon dlon self-requested a review April 11, 2025 07:57
dlon
dlon previously approved these changes Apr 11, 2025
Copy link
Copy Markdown
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion


desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):

#. %(openVpn)s - Will be replaced with OpenVPN
msgctxt "in-app-notifications"
msgid "%(openVpn)s support has ended. Please update the app or"

Is this string supposed to cut off like this?

Copy link
Copy Markdown
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion (waiting on @olmoh)


desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Is this string supposed to cut off like this?

I suppose so if it's split over multiple lines, but @olmoh might have more insight here!

Copy link
Copy Markdown
Collaborator

@olmoh olmoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion (waiting on @hulthe and @MarkusPettersson98)


desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

I suppose so if it's split over multiple lines, but @olmoh might have more insight here!

Yes, this will be followed by a link to vpn settings, which is in a separate string. 🙂

Copy link
Copy Markdown
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 57 files reviewed, all discussions resolved


desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):

Previously, olmoh (Oliver Mohlin) wrote…

Yes, this will be followed by a link to vpn settings, which is in a separate string. 🙂

Nice, thanks for the clarification!

Copy link
Copy Markdown
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 57 of 57 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/lib/resource/src/main/res/values-my/strings.xml line 160 at r1 (raw file):

    <string name="enable_custom_dns">စိတ်ကြိုက် DNS ဆာဗာကို သုံးရန်</string>
    <string name="enable_direct_only">%1$s ကို ဖွင့်ရန်</string>
    <string name="enable_ipv6">In-tunnel IPv6</string>

What happened here? 🙃 Seems like this string is not translated in all languages?

Rawa
Rawa previously approved these changes Apr 11, 2025
Copy link
Copy Markdown
Collaborator

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 57 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions


desktop/packages/mullvad-vpn/locales/my/messages.po line 2619 at r1 (raw file):

msgid "In-tunnel IPv6"
msgstr "In-tunnel IPv6"

This seems to have been missed?


desktop/packages/mullvad-vpn/locales/it/messages.po line 2625 at r1 (raw file):

msgid "In-tunnel IPv6"
msgstr "In-tunnel IPv6"

This does not feel translated at all.


desktop/packages/mullvad-vpn/locales/pt/messages.po line 2625 at r1 (raw file):

msgid "In-tunnel IPv6"
msgstr "In-tunnel IPv6"

No translation?

Copy link
Copy Markdown
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions


android/lib/resource/src/main/res/values-my/strings.xml line 160 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

What happened here? 🙃 Seems like this string is not translated in all languages?

It is translated on desktop.. @Pururun will have a look 😊

@MarkusPettersson98
Copy link
Copy Markdown
Contributor Author

I've asked Alconost whats up. To be continued:)

Copy link
Copy Markdown
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Pururun)


desktop/packages/mullvad-vpn/locales/it/messages.po line 2625 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This does not feel translated at all.

Alconost assured this is "correct"


desktop/packages/mullvad-vpn/locales/my/messages.po line 2619 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This seems to have been missed?

Alconost assured this is "correct"


desktop/packages/mullvad-vpn/locales/pt/messages.po line 2625 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

No translation?

Alconost assured this is "correct"

Pururun
Pururun previously approved these changes Apr 15, 2025
Copy link
Copy Markdown
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 dismissed stale reviews from Pururun, Rawa, and dlon via 77fcf5f April 15, 2025 12:06
Copy link
Copy Markdown
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit effafb6 into main Apr 15, 2025
31 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the update-translations branch April 15, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants