Conversation
hulthe
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion
desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):
#. %(openVpn)s - Will be replaced with OpenVPN msgctxt "in-app-notifications" msgid "%(openVpn)s support has ended. Please update the app or"
Is this string supposed to cut off like this?
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion (waiting on @olmoh)
desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Is this string supposed to cut off like this?
I suppose so if it's split over multiple lines, but @olmoh might have more insight here!
olmoh
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 57 files reviewed, 1 unresolved discussion (waiting on @hulthe and @MarkusPettersson98)
desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
I suppose so if it's split over multiple lines, but @olmoh might have more insight here!
Yes, this will be followed by a link to vpn settings, which is in a separate string. 🙂
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 57 files reviewed, all discussions resolved
desktop/packages/mullvad-vpn/locales/sv/messages.po line 929 at r1 (raw file):
Previously, olmoh (Oliver Mohlin) wrote…
Yes, this will be followed by a link to vpn settings, which is in a separate string. 🙂
Nice, thanks for the clarification!
Rawa
left a comment
There was a problem hiding this comment.
Reviewed 57 of 57 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
android/lib/resource/src/main/res/values-my/strings.xml line 160 at r1 (raw file):
<string name="enable_custom_dns">စိတ်ကြိုက် DNS ဆာဗာကို သုံးရန်</string> <string name="enable_direct_only">%1$s ကို ဖွင့်ရန်</string> <string name="enable_ipv6">In-tunnel IPv6</string>
What happened here? 🙃 Seems like this string is not translated in all languages?
Rawa
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
left a comment
There was a problem hiding this comment.
Reviewed 1 of 57 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions
desktop/packages/mullvad-vpn/locales/my/messages.po line 2619 at r1 (raw file):
msgid "In-tunnel IPv6" msgstr "In-tunnel IPv6"
This seems to have been missed?
desktop/packages/mullvad-vpn/locales/it/messages.po line 2625 at r1 (raw file):
msgid "In-tunnel IPv6" msgstr "In-tunnel IPv6"
This does not feel translated at all.
desktop/packages/mullvad-vpn/locales/pt/messages.po line 2625 at r1 (raw file):
msgid "In-tunnel IPv6" msgstr "In-tunnel IPv6"
No translation?
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions
android/lib/resource/src/main/res/values-my/strings.xml line 160 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
What happened here? 🙃 Seems like this string is not translated in all languages?
It is translated on desktop.. @Pururun will have a look 😊
|
I've asked Alconost whats up. To be continued:) |
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Pururun)
desktop/packages/mullvad-vpn/locales/it/messages.po line 2625 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
This does not feel translated at all.
Alconost assured this is "correct"
desktop/packages/mullvad-vpn/locales/my/messages.po line 2619 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
This seems to have been missed?
Alconost assured this is "correct"
desktop/packages/mullvad-vpn/locales/pt/messages.po line 2625 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
No translation?
Alconost assured this is "correct"
Pururun
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
77fcf5f
bbe6547 to
77fcf5f
Compare
Pururun
left a comment
There was a problem hiding this comment.
Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR updates the app with new translations for the coming 2025.6 release 🚀
This change is