Remove error-chain and replace with handcrafted errors#107
Merged
Conversation
faern
force-pushed
the
remove-error-chain
branch
from
bf21ccc to
c6a87e2
Compare
faern
changed the title
This changes the API of the error a lot, and the returned error chain in many calls into this library
faern
force-pushed
the
remove-error-chain
branch
from
c6a87e2 to
3cca651
Compare
Serock3
approved these changes
Jul 19, 2024
Serock3
left a comment
Serock3
left a comment
There was a problem hiding this comment.
Nice work! I like your implementation, although I probably would have preferred to use thiserror myself because of its simplicity, ubiquity and the fact that it would produce a very similar end product. Since you've already written it by hand I see no reason to change it, however
Reviewed 12 of 12 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the API of the error a lot, and the returned error chain in many calls into this library.
This supersedes #88. I'm not saying we absolutely have to stay away from
thiserror. But I had some questions about the details in that PR so I decided to try my own approach. And I like this approach. The error was easy to implement manually.I have tried these changes out in our main app, and it does not create any trouble. We don't really match against the errors anywhere, so it just compiles with no changes. The error chain will print a bit differently if we run into an error, but hopefully the changes or not for the worse.
This change is