Skip to content

Move axios request config option into main uploadTable options argument #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move axios request config option into main uploadTable options argument #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b011d
Move axios request config option into main uploadTable options argument
waxlamp Aug 3, 2020
d27d043
Separate axiosRequestConfig into a general options interface
waxlamp Aug 5, 2020
5211ce8
Merge branch 'master' into axios-config
waxlamp Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ export function validUploadType(type: string): type is UploadType {

export type Direction = 'all' | 'incoming' | 'outgoing';

export interface OptionsSpec {
axiosRequestConfig?: AxiosRequestConfig;
}

export interface TablesOptionsSpec {
type?: TableType;
}
Expand All @@ -75,7 +79,7 @@ export type EdgesOptionsSpec = OffsetLimitSpec & {
direction?: Direction;
};

export interface FileUploadOptionsSpec {
export interface FileUploadOptionsSpec extends OptionsSpec {
type: UploadType;
data: string | File;
key?: string;
Expand Down Expand Up @@ -177,8 +181,9 @@ class MultinetAPI {
}

public async uploadTable(
workspace: string, table: string, options: FileUploadOptionsSpec, config?: AxiosRequestConfig
workspace: string, table: string, options: FileUploadOptionsSpec
): Promise<Array<{}>> {
const config = options.axiosRequestConfig;
const headers = config ? config.headers : undefined;
const params = config ? config.params : undefined;
const { type, data, key, overwrite } = options;
Expand Down