Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Integrate Outgoing miniblocks with type #6795

Open
wants to merge 10 commits into
base: MX-16438-send-bitmap-outgoing-operations
Choose a base branch
from

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Feb 11, 2025

Reasoning behind the pull request

  • Refactor outgoing miniblock to use a slice of outgoing miniblocks with type

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic changed the title FEAT: Bring core go mod with outgoing miniblocks [sovereign] Integrate Outgoing miniblocks with type Feb 12, 2025
@mariusmihaic mariusmihaic changed the base branch from feat/sov-set-epoch-change-validators to MX-16438-send-bitmap-outgoing-operations February 13, 2025 13:39
…-outgoing-miniblocks-with-type

# Conflicts:
#	cmd/sovereignnode/go.mod
#	consensus/spos/bls/sovereignSubRoundEndOutGoingTxData.go
#	consensus/spos/bls/sovereignSubRoundSignatureOutGoingTxData.go
#	go.mod
#	process/block/sovereignChainBlock_test.go
@mariusmihaic mariusmihaic marked this pull request as ready for review February 13, 2025 14:44
@mariusmihaic mariusmihaic self-assigned this Feb 13, 2025
@@ -1,13 +1,14 @@
package block

import (
vmcommon "github.com/multiversx/mx-chain-vm-common-go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants