Skip to content

Merge main in next branch - #645

Merged
danielailie merged 15 commits into
feat/nextfrom
Merge-main-in-next-branch
Jul 24, 2025
Merged

Merge main in next branch#645
danielailie merged 15 commits into
feat/nextfrom
Merge-main-in-next-branch

Conversation

@danielailie

Copy link
Copy Markdown
Contributor

No description provided.

@danielailie danielailie self-assigned this Jul 24, 2025
@danielailie danielailie added the ignore-for-release-notes Ignore for release notes label Jul 24, 2025
@danielailie
danielailie changed the base branch from main to feat/next July 24, 2025 11:49
@andreibancioiu
andreibancioiu requested a review from Copilot July 24, 2025 11:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation and examples for multisig functionality to the SDK cookbook by merging main branch changes into the next branch.

  • Added comprehensive multisig documentation with examples for both controller and factory patterns
  • Integrated the new multisig.ts file into the cookbook generation process
  • Generated updated cookbook.md with multisig examples covering deployment, proposing actions, and querying

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cookbook/multisig.ts New cookbook example demonstrating multisig contract deployment, action proposals, and querying using both controller and factory patterns
cookbook/generate.py Added multisig.ts to the list of files processed during cookbook generation
cookbook/cookbook.md Auto-generated documentation containing the formatted multisig examples and explanations

Comment thread cookbook/multisig.ts
Comment on lines +141 to +148
const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, {
multisigContract: contract,
to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"),
gasLimit: 10000000n,
nativeTokenAmount: 1000000000000000000n,
});
// fetch the nonce of the network // md-as-comment
alice.nonce = await entrypoint.recallAccountNonce(alice.address);

Copilot AI Jul 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nonce is fetched after creating the transaction but should be fetched before creating the transaction. This creates inconsistency with the controller pattern shown earlier and may cause nonce synchronization issues.

Suggested change
const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, {
multisigContract: contract,
to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"),
gasLimit: 10000000n,
nativeTokenAmount: 1000000000000000000n,
});
// fetch the nonce of the network // md-as-comment
alice.nonce = await entrypoint.recallAccountNonce(alice.address);
// fetch the nonce of the network // md-as-comment
alice.nonce = await entrypoint.recallAccountNonce(alice.address);
const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, {
multisigContract: contract,
to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"),
gasLimit: 10000000n,
nativeTokenAmount: 1000000000000000000n,
});

Copilot uses AI. Check for mistakes.
@danielailie
danielailie merged commit 009ba80 into feat/next Jul 24, 2025
@danielailie
danielailie deleted the Merge-main-in-next-branch branch July 24, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants