Merge main in next branch - #645
Merged
Merged
Conversation
…tation Tool 641 add multisig documentation
andreibancioiu
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation and examples for multisig functionality to the SDK cookbook by merging main branch changes into the next branch.
- Added comprehensive multisig documentation with examples for both controller and factory patterns
- Integrated the new multisig.ts file into the cookbook generation process
- Generated updated cookbook.md with multisig examples covering deployment, proposing actions, and querying
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cookbook/multisig.ts | New cookbook example demonstrating multisig contract deployment, action proposals, and querying using both controller and factory patterns |
| cookbook/generate.py | Added multisig.ts to the list of files processed during cookbook generation |
| cookbook/cookbook.md | Auto-generated documentation containing the formatted multisig examples and explanations |
Comment on lines
+141
to
+148
| const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, { | ||
| multisigContract: contract, | ||
| to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"), | ||
| gasLimit: 10000000n, | ||
| nativeTokenAmount: 1000000000000000000n, | ||
| }); | ||
| // fetch the nonce of the network // md-as-comment | ||
| alice.nonce = await entrypoint.recallAccountNonce(alice.address); |
There was a problem hiding this comment.
The nonce is fetched after creating the transaction but should be fetched before creating the transaction. This creates inconsistency with the controller pattern shown earlier and may cause nonce synchronization issues.
Suggested change
| const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, { | |
| multisigContract: contract, | |
| to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"), | |
| gasLimit: 10000000n, | |
| nativeTokenAmount: 1000000000000000000n, | |
| }); | |
| // fetch the nonce of the network // md-as-comment | |
| alice.nonce = await entrypoint.recallAccountNonce(alice.address); | |
| // fetch the nonce of the network // md-as-comment | |
| alice.nonce = await entrypoint.recallAccountNonce(alice.address); | |
| const transaction = await factory.createTransactionForProposeTransferExecute(alice.address, { | |
| multisigContract: contract, | |
| to: Address.newFromBech32("erd1k2s324ww2g0yj38qn2ch2jwctdy8mnfxep94q9arncc6xecg3xaq6mjse8"), | |
| gasLimit: 10000000n, | |
| nativeTokenAmount: 1000000000000000000n, | |
| }); |
popenta
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.