Cookbook: Add actual implementation for load abi and load bytecode by danielailie · Pull Request #646 · multiversx/mx-sdk-js-core

danielailie · 2025-07-24T13:11:42Z

No description provided.

andreibancioiu · 2025-07-24T13:32:10Z

+        const json = JSON.parse(jsonContent);
+        const abi = Abi.create(json);


Since we are in the cookbook, we can also use a one-liner:

const abi = Abi.create(JSON.parse(jsonContent));

andreibancioiu · 2025-07-24T13:32:28Z

@@ -1,3 +1,5 @@
+export * from "./multisigController";


Copilot

Pull Request Overview

This PR replaces test utility functions with direct file system operations for loading ABI files and bytecode, making the cookbook examples self-contained without external test utilities. The changes include a version bump to 15.0.0-beta.0 and new exports from the multisig module.

Key changes:

Replace loadAbiRegistry() and loadContractCode() test utilities with direct fs.promises.readFile() calls
Update import statements to use fs module instead of test utilities
Add new exports for multisig controller and outcome parser

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
src/multisig/index.ts	Adds exports for multisigController and multisigTransactionsOutcomeParser
package.json	Bumps version from 14.2.9 to 15.0.0-beta.0
cookbook/smartContracts.ts	Replaces test utility functions with direct fs operations for ABI/bytecode loading
cookbook/multisig.ts	Replaces test utility functions with direct fs operations for ABI/bytecode loading
cookbook/cookbook.md	Updates documentation to reflect the new fs-based approach

Copilot · 2025-07-25T09:38:27Z

+        const bytecode = await fs.promises.readFile("../src/testData/adder.wasm");
        // load the abi file
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:28Z

        // We use the transaction hash we got when broadcasting the transaction
-
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:28Z


        // load the abi file
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Copilot · 2025-07-25T09:38:28Z


        // load the abi file
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:28Z

        // load the abi file
        const entrypoint = new DevnetEntrypoint();
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:29Z

    // ```js
    {
-        const abi = await loadAbiRegistry("../src/testdata/multisig-full.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/multisig-full.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/multisig-full.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/multisig-full.abi.json", {

Copilot · 2025-07-25T09:38:29Z

    // ```js
    {
-        const abi = await loadAbiRegistry("../src/testdata/multisig-full.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/multisig-full.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/multisig-full.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/multisig-full.abi.json", {

Copilot · 2025-07-25T09:38:29Z

        const entrypoint = new DevnetEntrypoint();
        const contractAddress = Address.newFromBech32("erd1qqqqqqqqqqqqqpgq7cmfueefdqkjsnnjnwydw902v8pwjqy3d8ssd4meug");
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:30Z


        // load the abi
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Suggested change

const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {

const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Copilot · 2025-07-25T09:38:30Z


        // load the abi
-        const abi = await loadAbiRegistry("../src/testdata/adder.abi.json");
+        const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {


Inconsistent path casing: this uses 'testdata' (lowercase) while other occurrences in the same file use 'testData' (camelCase). This could cause file not found errors on case-sensitive file systems.

Add actual implementation for load abi and load bytecode

6fc6789

danielailie self-assigned this Jul 24, 2025

andreibancioiu requested a review from Copilot July 24, 2025 13:15

This comment was marked as outdated.

Sign in to view

Fix abi path

9a31c58

andreibancioiu requested a review from Copilot July 24, 2025 13:30

This comment was marked as outdated.

Sign in to view

andreibancioiu previously approved these changes Jul 24, 2025

View reviewed changes

Fix documentation

bcabbdd

danielailie dismissed andreibancioiu’s stale review via bcabbdd July 25, 2025 09:24

Bump version

5b875d8

popenta previously approved these changes Jul 25, 2025

View reviewed changes

andreibancioiu previously approved these changes Jul 25, 2025

View reviewed changes

andreibancioiu requested a review from Copilot July 25, 2025 09:36

Copilot AI reviewed Jul 25, 2025

View reviewed changes

andreibancioiu changed the title ~~Add actual implementation for load abi and load bytecode~~ Cookbook: Add actual implementation for load abi and load bytecode Jul 25, 2025

fix path inconsistency

8d5f178

danielailie dismissed stale reviews from andreibancioiu and popenta via 8d5f178 July 25, 2025 11:25

andreibancioiu approved these changes Jul 25, 2025

View reviewed changes

popenta approved these changes Jul 25, 2025

View reviewed changes

danielailie merged commit 8a7adf9 into feat/next Jul 25, 2025

danielailie deleted the TOOL-647-update-documentation-for-load-abi-and-contract-code branch July 25, 2025 11:40

		const json = JSON.parse(jsonContent);
		const abi = Abi.create(json);

	const jsonContent: string = await fs.promises.readFile("../src/testdata/adder.abi.json", {
	const jsonContent: string = await fs.promises.readFile("../src/testData/adder.abi.json", {

Uh oh!

Conversation

danielailie commented Jul 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

andreibancioiu Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

andreibancioiu Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants