Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubkey converter refactor #158

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Pubkey converter refactor #158

wants to merge 15 commits into from

Conversation

schimih
Copy link
Contributor

@schimih schimih commented Nov 23, 2022 •
edited
Loading

  • Pending the PubkeyConverter refactoring and sovereign chains, the actual hrp erd should not be a constant and unchangeable value.
  • Changes:
  1. Address(..) accepts now an optional hrp, other than the default one DEFAULT_HRP= "erd";
  2. _decode_bech32(..) doesn't check for "erd" anymore and returns the decoded hrp;
  3. Install libtinfo5 for ubuntu-latest.

@schimih schimih self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiu725 claudiu725 claudiu725 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@schimih schimih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schimih @claudiu725