feat: add turbostat plugin #1469
Open
+217
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
reviewed
Jan 9, 2025
plugins/sensors/turbostat_
Outdated
Comment on lines
160
to
173
| function in_array { | ||
| local e match | ||
| match="$1" | ||
| shift | ||
| for e; do [[ "$e" == "$match" ]] && return 0; done | ||
| return 1 | ||
| } | ||
|
|
||
| # Join array elements by separator | ||
| function join { | ||
| local IFS="$1" | ||
| shift | ||
| echo "$*" | ||
| } |
There was a problem hiding this comment.
Indentation style for these two functions doesn't match the rest of the file. Do you want to fix that?
There was a problem hiding this comment.
Fixed, you got me copying code from SO instead of writing it myself ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See embedded plugin docs for description etc
It might be weird that this is a multigraph plugin with only one graph, but wanted to be prepared for if I overlooked something other useful to monitoring using turbostat. Feel free to let me know if you have suggestions which graphs to add, but things like temperatures can already be monitored using the
sensors_plugin which uses the same source so imho not really useful to add those in this plugin too