netstat: drop netstat -s dep by using /proc/net/snmp data directly
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rany2
force-pushed
the
drop-netstat-s-dep
branch
from
853e750 to
2b1c5c5
Compare
rany2
force-pushed
the
drop-netstat-s-dep
branch
from
2b1c5c5 to
49dd8f9
Compare
This allows the plugin to work under OpenWRT as the busybox netstat does not support `netstat -s`. Fixes: munin-monitoring#14 Signed-off-by: Rany Hany <[email protected]>
rany2
force-pushed
the
drop-netstat-s-dep
branch
from
49dd8f9 to
cd0d447
Compare
rany2
added a commit
to rany2/openwrt_packages
that referenced
this pull request
Jan 2, 2025
As muninlite doesn't appear to have had a release in a few years and activity on the git repo appears to have stalled, we add some patches on our end for now. Patches: - 001->004 are upstream fixes from master. - 100 is a submitted PR: munin-monitoring/muninlite#19 to fix munin-monitoring/muninlite#14. - 200->204 is a submitted PR to allow customizing the monitored network interfaces: munin-monitoring/muninlite#18. Despite the large number of patches it is actually a trivial change. Signed-off-by: Rany Hany <[email protected]>
rany2
added a commit
to rany2/openwrt_packages
that referenced
this pull request
Jan 2, 2025
As muninlite doesn't appear to have had a release in a few years and activity on the git repo appears to have stalled, we add some patches on our end for now. Patches: - 001->004 are upstream fixes from master. - 100 is a submitted PR: munin-monitoring/muninlite#19 to fix munin-monitoring/muninlite#14. - 200->204 is a submitted PR to allow customizing the monitored network interfaces: munin-monitoring/muninlite#18. Despite the large number of patches it is actually a trivial change. Signed-off-by: Rany Hany <[email protected]>
|
Dear @munin-monitoring team, @ssm, @kenyon, @steveschnepp, @mattthias, @quentin-st, @sumpfralle, @kimheino, @daald, @dotmpe: Can you check this @rany2 PR? It is possible to create a new version after? Thanks in advance. |
kenyon
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the plugin to work under OpenWRT as the busybox netstat does not support
netstat -s.Fixes: #14