Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netstat: drop netstat -s dep by using /proc/net/snmp data directly #19

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

rany2
Copy link
Contributor

@rany2 rany2 commented Jan 2, 2025

This allows the plugin to work under OpenWRT as the busybox netstat does not support netstat -s.

Fixes: #14

This allows the plugin to work under OpenWRT as the busybox netstat
does not support `netstat -s`.

Fixes: #14
Signed-off-by: Rany Hany <[email protected]>
@rany2 rany2 force-pushed the drop-netstat-s-dep branch from 49dd8f9 to cd0d447 Compare January 2, 2025 13:20
@Neustradamus
Copy link

Dear @munin-monitoring team, @ssm, @kenyon, @steveschnepp, @mattthias, @quentin-st, @sumpfralle, @kimheino, @daald, @dotmpe: Can you check this @rany2 PR?

It is possible to create a new version after?

Thanks in advance.

BKPepe pushed a commit to openwrt/packages that referenced this pull request Jan 9, 2025
As muninlite doesn't appear to have had a release in a few years and activity
on the git repo appears to have stalled, we add some patches on our end for now.

Patches:

- 001->004 are upstream fixes from master.
- 100 is a submitted PR: munin-monitoring/muninlite#19
  to fix munin-monitoring/muninlite#14.
- 200->204 is a submitted PR to allow customizing the monitored network interfaces:
  munin-monitoring/muninlite#18. Despite the large
  number of patches it is actually a trivial change.

Signed-off-by: Rany Hany <[email protected]>
@Neustradamus
Copy link

Dear @munin-monitoring, @ssm, @kenyon, @steveschnepp, @mattthias, @quentin-st,

For informations, it has been added in OpenWrt:

The world waits you...

@kenyon kenyon merged commit 7f6616d into munin-monitoring:master Jan 10, 2025
@Neustradamus
Copy link

@kenyon: Thanks for the merging of @rany2 PR, good job!

@rany2: What other PRs can be closed after your PR merging?

@rany2 rany2 deleted the drop-netstat-s-dep branch January 10, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

OpenWRT netstat -s command not present
3 participants