Skip to content

Keep optional pnpm cache failures from blocking CI - #143

Merged
munirad7s merged 1 commit into
mainfrom
fix/142-pnpm-cache-path
Aug 12, 2026
Merged

Keep optional pnpm cache failures from blocking CI#143
munirad7s merged 1 commit into
mainfrom
fix/142-pnpm-cache-path

Conversation

@munirad7s

Copy link
Copy Markdown
Owner

Summary

  • resolve the pnpm store through a guarded Hermit-aware helper with three attempts
  • skip only optional cache restore/save when pnpm cannot yield a non-empty absolute path
  • keep dependency installation and every Desktop Core/smoke/integration job mandatory
  • add an always-run workflow contract covering success, retry, failure, empty output, and all cache consumers

Run 31636239395 showed Hermit's lazy pnpm download returning HTTP 503. The previous echo "STORE_PATH=$(pnpm store path --silent)" masked that command-substitution failure and passed an empty path to actions/cache.

Related issue

Closes #142

Testing

  • bash -n scripts/resolve-pnpm-cache-path.sh
  • bash -n scripts/test-ci-pnpm-cache-contract.sh
  • bash scripts/test-ci-pnpm-cache-contract.sh
  • parsed .github/workflows/ci.yml with PyYAML
  • git diff --check
  • just ci attempted twice; both local runs reached Clippy and were blocked only by an unchanged external sherpa-onnx archive download ending with Network Error: Unexpected EOF

Signed-off-by: Munir Adas <m.muniradas@gmail.com>
Copilot AI lite review requested due to automatic review settings August 12, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@munirad7s
munirad7s merged commit b918217 into main Aug 12, 2026
62 of 69 checks passed
@munirad7s
munirad7s deleted the fix/142-pnpm-cache-path branch August 12, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P2: Desktop-Core-CI scheitert vor Tests am pnpm-Cache ohne path

2 participants