Skip to content

Conversation

MaxEtMoritz
Copy link

Partial fix for #569 (all tracks and not just top 25 tracks are imported now. Featuring artists are still missing)
Additional improvements:

  • Multi-Disk releases are now correctly submitted as multiple media to MB
  • ISRC submission from Deezer is now possible

murdos#569 partial fix (first bullet point)
additional improvements:
- correctly submit multi-medium releases
- track ISRCs are available for submission (not implemented yet)
@MaxEtMoritz
Copy link
Author

Currently i more-or-less copy-pasted most of the ISRC stuff from another importer script (beatport). But in the long run i guess it's better to make it a library function (MBImport.buildIsrcButton(release) or similar). What do the devs think about this?

When i have time i could try to do that if this is desired.

@MaxEtMoritz
Copy link
Author

Another small improvement to ISRC submission:
since MagicISRC now also supports submitting and seeding an edit note, i added the default edit note for ISRC submissions.
@murdos could you have a look at the PR?

@murdos
Copy link
Owner

murdos commented Jun 25, 2025

@MaxEtMoritz : could you fix the lint issues?

@MaxEtMoritz
Copy link
Author

@murdos sorry, done now.
Switched PC since i last worked on it and forgot to npm install, so the git hooks didn't trigger...
And i wasn't aware i had set my VSCode formatter to Prettier and not ESLint, so only half of the linting was done.

@murdos
Copy link
Owner

murdos commented Jun 25, 2025

@MaxEtMoritz : no problem. And sorry for not having reviewed your PR earlier 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants