Only unregister the listener when eph is true #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this repo, it helped me a lot to grasp the basics of asynchronous servers under linux !
Nevertheless -on my config- after any request, the current version of this repo will panic at the end of the connection, when dropping the
AsyncTcpStream
, with this error:epoll:ctl_del_rawfd:error: No such file or directory
My guess is, when a tcp stream is dropped, it's already been automatically unregistered from its
Epoll
file descriptor set, because of the use of the flag EPOLLONESHOTA quick way to solve this is to check if the stream still belong to an Epoll file descriptor set, by looking at
stream.eph
flag.