feat: Make speak block on the utterance on Android (fixes #1092) #1094

jessielw · 2023-10-25T14:37:40Z

No description provided.

android/app/src/main/kotlin/com/rtirl/chat/MainActivity.kt

refactor: return result.success(true) onDone method

android/app/src/main/kotlin/com/rtirl/chat/MainActivity.kt

feat: Make speak block on the utterance on Android (fixes #1092)

793612c

jessielw requested a review from kevmo314 October 25, 2023 14:37

kevmo314 reviewed Oct 26, 2023

View reviewed changes

android/app/src/main/kotlin/com/rtirl/chat/MainActivity.kt Outdated Show resolved Hide resolved

kevmo314 reviewed Oct 26, 2023

View reviewed changes

android/app/src/main/kotlin/com/rtirl/chat/MainActivity.kt Outdated Show resolved Hide resolved

jessielw added 2 commits October 29, 2023 16:17

refactor: generated a random UUID() instead of a hardcoded string

96e6888

refactor: return result.success(true) onDone method

fix: compile error due to missing imports and args

76cb4e3

jessielw requested a review from kevmo314 October 29, 2023 20:25

Merge branch 'main' into speak-utterance-andriod

3e73e2a

kevmo314 requested changes Oct 29, 2023

View reviewed changes

android/app/src/main/kotlin/com/rtirl/chat/MainActivity.kt Show resolved Hide resolved

jessielw added 2 commits October 30, 2023 13:28

fix: speak method was not being properly called in method handler above

faa4ff7

fix: properly call the speak method

7d1f9be

jessielw requested a review from kevmo314 October 30, 2023 18:38

kevmo314 approved these changes Oct 30, 2023

View reviewed changes

jessielw merged commit 49ec0a0 into main Oct 30, 2023
4 checks passed

jessielw deleted the speak-utterance-andriod branch October 30, 2023 19:48

Provide feedback