fix: image quality #1319
Merged
fix: image quality #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
kevmo314
reviewed
Aug 21, 2024
There was a problem hiding this comment.
It says medium is the best for downscaling? https://api.flutter.dev/flutter/dart-ui/FilterQuality.html
If the emotes don't look high quality we probably need to download a higher res
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
That should have been medium, its not that the emotes don't look high res enough it was just finding the right balance since it felt like some animated ones slowed things down. I wasn't sure enough which is why I tried this tweak and thought I would get more input from you. |
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
kevmo314
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this would help or if you have any suggestions on improving this