fix: metadata lookup failure handling #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `add` method in `lib/screens/settings/audio_sources.dart` to handle metadata lookup failures. * **Metadata Fetching:** - Wrap `MetadataFetch.extract` call with a try/catch block to handle potential exceptions. - Assign `null` to `metadata` if an exception occurs. - Use the URL hostname as the title if metadata lookup fails. * **Audio Source Addition:** - Update the `addSource` method to use the title derived from metadata or URL hostname. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/muxable/rtchat?shareId=XXXX-XXXX-XXXX-XXXX).
kevmo314
temporarily deployed
to
android-internal
GitHub Actions
Inactive
kevmo314
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
addmethod inlib/screens/settings/audio_sources.dartto handle metadata lookup failures.Metadata Fetching:
MetadataFetch.extractcall with a try/catch block to handle potential exceptions.nulltometadataif an exception occurs.Audio Source Addition:
addSourcemethod to use the title derived from metadata or URL hostname.For more details, open the Copilot Workspace session.