left pane nav panel extending all the way to the top#402
Open
paulbettner wants to merge 6 commits intomuxy-app:mainfrom
Open
left pane nav panel extending all the way to the top#402paulbettner wants to merge 6 commits intomuxy-app:mainfrom
paulbettner wants to merge 6 commits intomuxy-app:mainfrom
Conversation
paulbettner
changed the title
Member
Thanks for the PR @paulbettner , I see an issue, toggling the sidebar multiple times causes it become empty |
paulbettner
force-pushed
the
pr/sidebar-titlebar-nav
branch
from
aad49a2 to
08d849c
Compare
Author
|
Argh! I'm so sorry to bother you with a bug on my first PR, @saeedvaziry! I just pushed a fix to this and one other issue I found with more rigorous code review. Thanks for your time/consideration! |
Member
|
No worries. I try to test every possible details. 
Somehow the PR has other regressions as well. |
Member
|
One moren thing, the sidebar toggle animation has been removed. any reason? it was sliding to close before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the top tab navigation bar extends above the left-hand workspace navigation panel, even though those tabs actually exist within the selected workspace. So I made an adjustment to "fix" this, extending the navigation panel so that it goes to the top of the window.
This is an opinionated UI PR, so please feel free to ignore it... but it makes more sense to me, visually, so I figured I'd submit this PR for your consideration.
Before:
After (this is from my fork):