fix(ebay): preserve commerce fields in agent compact output#1424
fix(ebay): preserve commerce fields in agent compact output#1424freemanconsulting wants to merge 2 commits into
Conversation
Greptile SummaryThis PR fixes
Confidence Score: 5/5Safe to merge; the allow-list expansion is additive and scoped to the eBay CLI only, tests cover both new field groups, and the patch file is correctly structured. All changed code is additive — no existing fields are removed or reordered, and the new fields are eBay-specific enough that false positives in other command outputs are unlikely. The patch file provenance values match
Important Files Changed
|
| // Commerce/search result fields. eBay's `listings`, `sold`, `comp`, and | ||
| // `auctions` commands are useless to agents if compact mode strips the | ||
| // price/condition/bid fields. `--agent` implies `--compact`, so these must | ||
| // survive the generic allow-list. | ||
| "item_id": true, "price": true, "sold_price": true, "currency": true, | ||
| "condition": true, "seller": true, "bids": true, "best_offer": true, | ||
| "auction": true, "buy_it_now": true, "time_left": true, "ends_at": true, | ||
| "sold_date": true, "image_url": true, "location": true, "shipping": true, | ||
| "mean": true, "median": true, "sample_size": true, "p25": true, | ||
| "p75": true, "std_dev": true, |
There was a problem hiding this comment.
Missing
.printing-press-patches/ entry for this generated-code edit
helpers.go lives inside generated output from the Printing Press; the project's AGENTS.md requires every hand-edit to be recorded under .printing-press-patches/ (a JSON file following the schema used by the three existing entries) so that a future regen carries the intent forward. Without a patch entry, the next printing-press regen will silently overwrite helpers.go and drop this fix, restoring the broken compact output for agents. All three existing patches in that directory (catalog-go-1264-vuln-floor.json, chrome-profile-cookie-selection.json, standalone-pycookiecheat-profile-selection.json) demonstrate the required format.
Context Used: library/commerce/ebay/AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary\n- keep eBay commerce fields in compact list output so --agent does not strip price/condition/bid data\n- adds regression coverage for listing/sold/auction and comp summary fields\n\n## Why\nThe eBay CLI documents --agent as JSON + compact + non-interactive. For commerce commands like listings/sold/auctions/comp, the generic compact allow-list kept title/url but dropped the fields agents actually need: price, condition, currency, bids, sold_price, etc. Downstream consumers had to avoid --agent to get usable pricing data.\n\n## Test\n- cd library/commerce/ebay && go test ./...\n