Make QUOTE_API_URL and PRICE_API_URL configurable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! generally i would have preferred for new functions that additionally allow the crate user to pass in optional URLs instead of introducing env vars. however that's certainly a bunch more work and probably not worth the roi and downstream impact. would you like me to publish a new version of this crate with this PR? |
|
a new crate version would probably make use more convenient |
|
🫡 i just published v0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to set base URL for quote and price API using environment variables so users can use self-hosted or paid-hosted Jupiter APIs.