Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Solana v1.18 #11

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Upgrade to Solana v1.18 #11

merged 3 commits into from
Oct 29, 2024

Conversation

joncinque
Copy link
Contributor

Problem

sys is still using 1.17 crates, even though 2.0 is about to hit mainnet.

Summary of changes

  • 7489fbd: It was a big change to upgrade to v2.0 directly, so only upgrade to v1.18 for now. During the upgrade to v2.0, the calls to get_stake_activation need to updated to use the client-side helper: https://github.com/anza-xyz/solana-rpc-client-extensions -- I can take care of that as follow-up work.
  • 1a53669: Remove the direct dependency on solana_vote_program as mentioned in one of the comments
  • 5e2ea36: since the get_fees RPC method was removed, I removed its usage, opting for get_fee_for_message instead <-- this is the most important change, since sys fails against mainnet right now because of this

@mvines
Copy link
Owner

mvines commented Oct 29, 2024

Awesome, thanks!

@mvines
Copy link
Owner

mvines commented Oct 29, 2024

Some clippy stuff in dependencies, gonna merge on red though

@mvines mvines merged commit e38fed2 into mvines:master Oct 29, 2024
1 check failed
@joncinque joncinque deleted the upsol branch October 29, 2024 18:00
@joncinque
Copy link
Contributor Author

I had initially fixed that too, but didn't want to add too much in the PR -- you just need to add test and client features in Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants