Adds new config migration script #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarning
reviewed
Aug 18, 2024
|
hi, I have added your migration scrip directlyt to the openwrt/packages MR. |
|
Ok. As soon as they merge it into the other repository I will delete the branch of this one so that it will be clean. |
ogarcia
commented
Aug 26, 2024
| > /dev/null 2>&1 || true | ||
|
|
||
| # Rename configuration to default | ||
| uci rename zerotier.@zerotier[0]='global' |
There was a problem hiding this comment.
Reviewing this carefully I realized that here I put default instead of global, I have just corrected it.
|
I have uploaded the change that adds support for what we discussed in #128. If you want to upload everything to openwrt/packages#24773 and I promise not to make any more changes until it has been merged. |
|
I close this PR since it is already applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add the configuration migration script to the new model introduced in #120
The script is quite simple. It generates the new
networkentries from thejoinlist, renames it tolocal_conf(which with the new configuration is calledlocal_conf_path) and renames the configuration todefaultso that it is loaded correctly by the new init script.All this is done with the user's first configuration. If the user has more than one configuration for having several instances up (something quite unlikely) the rest are simply ignored and it is up to the user to evaluate what he/she wants to do.